From 94d0b53a8eff2419a465fca57bf9a9c925cf4075 Mon Sep 17 00:00:00 2001
From: Bertrand Lemasle <blemasle@gmail.com>
Date: Sat, 4 Aug 2018 21:15:26 +1200
Subject: [PATCH] Revert "Using a common buffer for both http and sms"

This reverts commit 3cfc7074d1ad15a3ea13c2eef45c2aac6e3d161e.
Common buffer implies that the buffer goes to static memory, which overflow the available SRAM.
---
 GpsTracker/Buffer.cpp                 |  9 ---------
 GpsTracker/Buffer.h                   | 11 -----------
 GpsTracker/Core.cpp                   | 20 +++++++++-----------
 GpsTracker/NetworkPositionsBackup.cpp | 14 +++++++-------
 4 files changed, 16 insertions(+), 38 deletions(-)
 delete mode 100644 GpsTracker/Buffer.cpp
 delete mode 100644 GpsTracker/Buffer.h

diff --git a/GpsTracker/Buffer.cpp b/GpsTracker/Buffer.cpp
deleted file mode 100644
index c119b2f..0000000
--- a/GpsTracker/Buffer.cpp
+++ /dev/null
@@ -1,9 +0,0 @@
-#include "Buffer.h"
-#include "string.h"
-
-
-namespace buffer {
-	char value[BUFFER_SIZE];
-
-	void clear() { memset(buffer::value, NULL, BUFFER_SIZE); }
-}
\ No newline at end of file
diff --git a/GpsTracker/Buffer.h b/GpsTracker/Buffer.h
deleted file mode 100644
index 8b92e30..0000000
--- a/GpsTracker/Buffer.h
+++ /dev/null
@@ -1,11 +0,0 @@
-#pragma once
-
-#define BUFFER_SIZE 170
-
-
-namespace buffer {
-	extern char value[BUFFER_SIZE];
-
-	void clear();
-
-}
\ No newline at end of file
diff --git a/GpsTracker/Core.cpp b/GpsTracker/Core.cpp
index b04ec30..60384ca 100644
--- a/GpsTracker/Core.cpp
+++ b/GpsTracker/Core.cpp
@@ -2,10 +2,9 @@
 #include "Config.h"
 #include "Flash.h"
 #include "Alerts.h"
-#include "Buffer.h"
 
 #define LOGGER_NAME "Core"
-#define SMS_MAX_SIZE		140
+#define SMS_BUFFER_SIZE		140
 #define NO_ALERTS_NOTIFIED	0
 
 using namespace utils;
@@ -17,12 +16,12 @@ namespace core {
 
 	namespace details {
 
-		void appendToSmsBuffer(const char * fmt, ...) {
+		void appendToSmsBuffer(char * buffer, const char * fmt, ...) {
 			va_list args;
 			va_start(args, fmt);
 
-			size_t bufferLeft = SMS_MAX_SIZE - strlen(buffer::value);
-			char * p = buffer::value + strlen(buffer::value);
+			size_t bufferLeft = SMS_BUFFER_SIZE - strlen(buffer);
+			char * p = buffer + strlen(buffer);
 			vsnprintf_P(p, bufferLeft, fmt, args);
 
 			va_end(args);
@@ -55,6 +54,7 @@ namespace core {
 
 	uint8_t notifyFailures(PositionEntryMetadata &metadata) {
 		SIM808RegistrationStatus networkStatus;
+		char buffer[SMS_BUFFER_SIZE] = "Alerts !\n";
 		const __FlashStringHelper * backupFailureString = F(" Backup battery failure ?\n");
 
 		uint8_t triggered = alerts::getTriggered(metadata);
@@ -65,21 +65,19 @@ namespace core {
 
 		if (!network::isAvailable(networkStatus.stat)) return NO_ALERTS_NOTIFIED;
 
-		buffer::clear();
-		strcpy_P(buffer::value, PSTR("Alerts !\n"));
 		if (bitRead(triggered, ALERT_BATTERY_LEVEL_1) || bitRead(triggered, ALERT_BATTERY_LEVEL_2)) {
-			details::appendToSmsBuffer(PSTR("- Battery at %d%%.\n"), metadata.batteryLevel);
+			details::appendToSmsBuffer(buffer, PSTR("- Battery at %d%%.\n"), metadata.batteryLevel);
 		}
 
 		if (bitRead(triggered, ALERT_RTC_CLOCK_FAILURE)) {
-			details::appendToSmsBuffer(PSTR("-RTC was stopped. %S"), backupFailureString);
+			details::appendToSmsBuffer(buffer, PSTR("-RTC was stopped. %S"), backupFailureString);
 		}
 
 		if (bitRead(triggered, ALERT_RTC_TEMPERATURE_FAILURE)) {
-			details::appendToSmsBuffer(PSTR("- Temperature is %dC. %S"), static_cast<uint16_t>(metadata.temperature * 100), backupFailureString);
+			details::appendToSmsBuffer(buffer, PSTR("- Temperature is %dC. %S"), static_cast<uint16_t>(metadata.temperature * 100), backupFailureString);
 		}
 
-		bool notified = network::sendSms(buffer::value);
+		bool notified = network::sendSms(buffer);
 		if (!notified) NOTICE_MSG("notifyFailure", "SMS not sent !");
 
 		network::powerOff();
diff --git a/GpsTracker/NetworkPositionsBackup.cpp b/GpsTracker/NetworkPositionsBackup.cpp
index 95f8651..5ec6c1e 100644
--- a/GpsTracker/NetworkPositionsBackup.cpp
+++ b/GpsTracker/NetworkPositionsBackup.cpp
@@ -7,9 +7,9 @@
 #include "Debug.h"
 #include "Hardware.h"
 #include "Network.h"
-#include "Buffer.h"
 
 #define LOGGER_NAME "Positions::backup::network"
+#define BUFFER_SIZE 170
 
 namespace positions {
 	namespace backup {
@@ -25,8 +25,8 @@ namespace positions {
 			}
 
 			bool NetworkPositionsBackup::appendPosition(PositionEntry &entry) {
-				buffer::clear();
-				snprintf_P(buffer::value, BUFFER_SIZE, PSTR("%d,%d,%d,%d,%d,%d,%d,"),
+				char buffer[BUFFER_SIZE];
+				snprintf_P(buffer, BUFFER_SIZE, PSTR("%d,%d,%d,%d,%d,%d,%d,"),
 					debug::freeRam(),
 					hardware::sim808::device.getSignalQuality().attenuation,
 					entry.metadata.batteryLevel,
@@ -35,14 +35,14 @@ namespace positions {
 					static_cast<uint8_t>(entry.metadata.status),
 					entry.metadata.timeToFix);
 
-				strcat(buffer::value, entry.position);
+				strcat(buffer, entry.position);
 
-				NOTICE_FORMAT("appendPosition", "Sending : %s", buffer::value);
+				NOTICE_FORMAT("appendPosition", "Sending : %s", buffer);
 				uint16_t responseCode = hardware::sim808::device.httpPost(
 					config::main::value.network.url,
 					F("text/gpstracker"),
-					buffer::value,
-					buffer::value,
+					buffer,
+					buffer,
 					BUFFER_SIZE
 				) == POSITIONS_CONFIG_NET_DEFAULT_EXPECTED_RESPONSE;